Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce IERS_A_URL_MIRROR for when IERS_A_URL is down #8308

Merged
merged 3 commits into from Dec 21, 2018

Conversation

pllim
Copy link
Member

@pllim pllim commented Dec 20, 2018

This PR introduces IERS_A_URL_MIRROR for when IERS_A_URL is down. Fix #8304

Local testing with -P coordinates --remote-data and -P utils --remote-data worked for me. ™️ I also checked that IERS_A_URL` was still down when those tests ran.

Note: Check numpy-dev job (set to be allowed to fail) and make sure it is green before merge.

Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for the quick implementation! Only one total nitpick (feel free to ignore and certainly avoid testing!)

astropy/utils/iers/iers.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #8308 into master will increase coverage by <.01%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8308      +/-   ##
==========================================
+ Coverage   86.73%   86.74%   +<.01%     
==========================================
  Files         385      385              
  Lines       58009    58028      +19     
  Branches     1060     1060              
==========================================
+ Hits        50317    50334      +17     
- Misses       7077     7079       +2     
  Partials      615      615
Impacted Files Coverage Δ
astropy/utils/iers/iers.py 92.16% <92.85%> (+0.19%) ⬆️
astropy/samp/hub.py 77.38% <0%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f938037...127c8e1. Read the comment docs.

astropy/utils/iers/iers.py Outdated Show resolved Hide resolved
@mhvk
Copy link
Contributor

mhvk commented Dec 21, 2018

Damn, I forgot my [skip ci]. Well, I guess at least we can see if circle ci now passes (it should).

@mhvk mhvk added the 💤 merge-when-ci-passes Do not use: We have auto-merge option now. label Dec 21, 2018
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with the final docstring change

@mhvk
Copy link
Contributor

mhvk commented Dec 21, 2018

OK, tests passed so merging!

A query mostly out of curiosity: I wondered why the travis tests just hung rather than show a time-out - is this because subsequent tests kept trying to download the file?

@mhvk mhvk merged commit d8c7dd0 into astropy:master Dec 21, 2018
@pllim pllim deleted the iers-mirror branch December 21, 2018 15:47
@pllim
Copy link
Member Author

pllim commented Dec 21, 2018

why the travis tests just hung rather than show a time-out

That I am not sure. Maybe it is stuck when one of the imports somehow try to download the file at test collection? 🤷‍♀️ (Just a blind guess.)

bsipocz pushed a commit that referenced this pull request Dec 24, 2018
Introduce IERS_A_URL_MIRROR for when IERS_A_URL is down
bsipocz pushed a commit that referenced this pull request Dec 24, 2018
Introduce IERS_A_URL_MIRROR for when IERS_A_URL is down
@bsipocz bsipocz removed the 🔥 Critical label Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
utils 💤 merge-when-ci-passes Do not use: We have auto-merge option now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants