New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce IERS_A_URL_MIRROR for when IERS_A_URL is down #8308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for the quick implementation! Only one total nitpick (feel free to ignore and certainly avoid testing!)
Codecov Report
@@ Coverage Diff @@
## master #8308 +/- ##
==========================================
+ Coverage 86.73% 86.74% +<.01%
==========================================
Files 385 385
Lines 58009 58028 +19
Branches 1060 1060
==========================================
+ Hits 50317 50334 +17
- Misses 7077 7079 +2
Partials 615 615
Continue to review full report at Codecov.
|
Damn, I forgot my [skip ci]. Well, I guess at least we can see if circle ci now passes (it should). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with the final docstring change
OK, tests passed so merging! A query mostly out of curiosity: I wondered why the travis tests just hung rather than show a time-out - is this because subsequent tests kept trying to download the file? |
That I am not sure. Maybe it is stuck when one of the imports somehow try to download the file at test collection? 🤷♀️ (Just a blind guess.) |
Introduce IERS_A_URL_MIRROR for when IERS_A_URL is down
Introduce IERS_A_URL_MIRROR for when IERS_A_URL is down
This PR introduces
IERS_A_URL_MIRROR
for whenIERS_A_URL
is down. Fix #8304Local testing with
-P coordinates --remote-data
and-P utils --remote-data
worked for me. ™️ I also checked that IERS_A_URL` was still down when those tests ran.Note: Check numpy-dev job (set to be allowed to fail) and make sure it is green before merge.