Units: speed improvement #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mdboom - FYI, if you really only need to do travis tests and don't care about PR features, you can go into travis's admin console and turn it on for your fork just long enough to push up a commit, and then turn it off again. That's how I've been doing it when I need to mess with travis configuration and similar sorts of test-testing tricks. |
embray
pushed a commit
to embray/astropy
that referenced
this pull request
Mar 29, 2013
Units: speed improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not re-decomposing units repeatedly, we get a 25% speedup in compose and decompose.
Not much controversial here -- mainly just submitting as a pull request to get Travis to give it a once over.