Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return types in FITSWCSAPIWrapper and SlicedLowLevelWCS #9678

Merged
merged 3 commits into from Nov 26, 2019

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented Nov 25, 2019

Found while working on #9677

@Cadair
Copy link
Member Author

Cadair commented Nov 25, 2019

4.0 bugfix

@pllim pllim added this to the v4.0.1 milestone Nov 25, 2019
@pllim pllim added the Bug label Nov 25, 2019
CHANGES.rst Outdated Show resolved Hide resolved
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I agree with @bsipocz about moving the changelog entry

@bsipocz bsipocz modified the milestones: v4.0.1, v4.0 Nov 25, 2019
@Cadair
Copy link
Member Author

Cadair commented Nov 26, 2019

I think it's now in the right place in the changelog.

@Cadair
Copy link
Member Author

Cadair commented Nov 26, 2019

Please hold on merging this, looks like I have some similar fixes for SlicedLowLevelWCS coming.

@Cadair Cadair changed the title Make FITS implementation of LowLevelWCS return tuples not lists Fix return types in FITSWCSAPIWrapper and SlicedLowLevelWCS Nov 26, 2019
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@astrofrog astrofrog merged commit 2c8d84e into astropy:master Nov 26, 2019
@Cadair Cadair deleted the fitswcs_ap14_tuples branch November 26, 2019 16:15
bsipocz pushed a commit that referenced this pull request Dec 1, 2019
Fix return types in FITSWCSAPIWrapper and SlicedLowLevelWCS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants