Change ECSV subtype=object to subtype=json #11662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pllim
added
the
Affects-dev
I think so, but @saimn should confirm. |
pllim
approved these changes
Apr 29, 2021
|
Yep, entries with the same message are merged: https://astropy--11662.org.readthedocs.build/en/11662/changelog.html#astropy-io-ascii |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Over in astropy/astropy-APEs#68 @mbtaylor requested this change, which seems like a good idea.
@saimn or @pllim - this is an example of a follow-on PR that is really part of #11569. I seem to recall that I am supposed to use the same feature message and this will then put both PR numbers in the change log. Did I get that right?