New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Use vanilla docker image from CircleCI #12032
TST: Use vanilla docker image from CircleCI #12032
Conversation
👋 Thank you for your draft pull request! Do you know that you can use |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicking, none of the comments are helping to resolve the failing build
mpldev did run, but the latex stuff changed... should I be worried about it or just update the "truth"? |
f8d5ecc
to
5ad78f7
Compare
This comment has been minimized.
This comment has been minimized.
452359e
to
081a2a4
Compare
I end up to have to get rid of numpy pinning to get rid of the weird numpy install error. The tests now run to completion but there are a ton of failures, which are not surprising, given the versions are now different from old Docker. Also some deprecation warnings from numpy. I am not sure how to proceed here. @astrofrog or @Cadair , please advise. |
TST: Bump dep versions TST: Re-enabled mpl311 test, use tox
d2a5afb
to
16c4b9b
Compare
Rebased to make sure the new truths I am about to grab are up-to-date. |
b80294f
to
41a93b0
Compare
I think this is ready for review now. |
Thanks @pllim! |
Description
This pull request is to address the problem of no one knows how to update the existing Docker images on the server, except maybe for one person who does not have the time.
Address part of #10483
Removes blocker for #11934
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CI
label.no-changelog-entry-needed
label.astropy-bot
check might be missing; do not let the green checkmark fool you.backport-X.Y.x
label(s) before merge.