Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Use vanilla docker image from CircleCI #12032

Merged
merged 8 commits into from Aug 25, 2021

Conversation

pllim
Copy link
Member

@pllim pllim commented Aug 9, 2021

Description

This pull request is to address the problem of no one knows how to update the existing Docker images on the server, except maybe for one person who does not have the time.

Address part of #10483

Removes blocker for #11934

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
  • Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label.
  • Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

@pllim pllim added this to the v5.0 milestone Aug 9, 2021
@github-actions
Copy link

github-actions bot commented Aug 9, 2021

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@pllim

This comment has been minimized.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicking, none of the comments are helping to resolve the failing build

.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
@pllim
Copy link
Member Author

pllim commented Aug 16, 2021

mpldev did run, but the latex stuff changed... should I be worried about it or just update the "truth"?

@pllim pllim force-pushed the you-spin-me-right-round-ci-right-round branch from f8d5ecc to 5ad78f7 Compare August 16, 2021 22:35
@pllim

This comment has been minimized.

@pllim pllim force-pushed the you-spin-me-right-round-ci-right-round branch 2 times, most recently from 452359e to 081a2a4 Compare August 19, 2021 13:36
@pllim
Copy link
Member Author

pllim commented Aug 19, 2021

I end up to have to get rid of numpy pinning to get rid of the weird numpy install error. The tests now run to completion but there are a ton of failures, which are not surprising, given the versions are now different from old Docker. Also some deprecation warnings from numpy. I am not sure how to proceed here. @astrofrog or @Cadair , please advise.

@pllim pllim force-pushed the you-spin-me-right-round-ci-right-round branch from d2a5afb to 16c4b9b Compare August 25, 2021 16:49
@pllim
Copy link
Member Author

pllim commented Aug 25, 2021

Rebased to make sure the new truths I am about to grab are up-to-date.

@pllim pllim marked this pull request as ready for review August 25, 2021 21:44
@pllim
Copy link
Member Author

pllim commented Aug 25, 2021

I think this is ready for review now. Should get this merged soon because CircleCI is now going to fail for everyone until we merge this... (or maybe not, since main still uses old data dir... my head hurts lol) 😬 🐔 🥚

@pllim pllim added 🔥 Critical Docs labels Aug 25, 2021
@bsipocz bsipocz merged commit 8902222 into astropy:main Aug 25, 2021
@bsipocz
Copy link
Member

bsipocz commented Aug 25, 2021

Thanks @pllim!

@pllim pllim deleted the you-spin-me-right-round-ci-right-round branch August 25, 2021 22:32
@pllim pllim mentioned this pull request Aug 25, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants