ENH: fix compatibility with numpy 1.23

[neutrinoceros]

Description

Fixes #12534
This is not necessarily sufficient to fix compatibility with numpy 1.23 completely but it should at least address the problem I stumbled upon.

for reference the breaking change upstream is from numpy/numpy#20414

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the Extra CI label.
• Is a change log needed? If yes, did the change log check pass? If no, add the no-changelog-entry-needed label. If this is a manual backport, use the skip-changelog-checks label unless special changelog handling is necessary.
• Is a milestone set? Milestone must be set but astropy-bot check might be missing; do not let the green checkmark fool you.
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate backport-X.Y.x label(s) before merge.

[neutrinoceros]

I don't know if this warrants a changelog entry, please tell me if I need to write one.

[mhvk]

Thanks very much for noticing that and sending the fix!! It looks all good. We should back-port this.

[mhvk]

The numpy-dev job passed, which included the numpy commit that removed the deprecated functions, so this PR is tested also for that.

[lumberbot-app]

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

1. Checkout backport branch and update it.

git checkout v5.0.x
git pull

2. Cherry pick the first parent branch of the this PR on top of the older branch:

git cherry-pick -m1 ee293f35829f6a5d2984284640e5ab231d48cd20

3. You will likely have some merge/cherry-pick conflict here, fix them and commit:

git commit -am 'Backport PR #12535: ENH: fix compatibility with numpy 1.23'

4. Push to a named branch:

git push YOURFORK v5.0.x:auto-backport-of-pr-12535-on-v5.0.x

5. Create a PR against branch v5.0.x, I would have named this PR:

"Backport PR #12535 on branch v5.0.x (ENH: fix compatibility with numpy 1.23)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.