Ensure that np.concatenate with dtype argument works on quantities and masked data #13323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhvk
added
units
Bug
utils.masked
💤 backport-v5.0.x
|
Both failures are unrelated - see #13322 |
|
It hard to prove this really fixed the problem because the dev job didn't run at all. I'll see if I can make the matplotlib stuff go away. |
|
Actually, it is not that bad: this does test with numpy 1.20, and that had a bug already. So, that is fixed by this PR. If we then rebase yours, we can check that it also solved the numpy-dev issues. |
|
@mhvk , please rebase. Thanks! |
mhvk
force-pushed
the
quantity-masked-concatenate-dtype-argument
branch
from
bb368dc
to
4036526
Compare
|
OK, rebased. Hopefully all the tests pass now! |
|
OK, all tests passed now! |
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Jun 11, 2022
…ment works on quantities and masked data
meeseeksmachine
pushed a commit
to meeseeksmachine/astropy
that referenced
this pull request
Jun 11, 2022
…ment works on quantities and masked data
|
Thanks for keeping a look-out for those |
mhvk
added a commit
that referenced
this pull request
Jun 11, 2022
…323-on-v5.1.x Backport PR #13323 on branch v5.1.x (Ensure that np.concatenate with dtype argument works on quantities and masked data)
mhvk
added a commit
that referenced
this pull request
Jun 11, 2022
…323-on-v5.0.x Backport PR #13323 on branch v5.0.x (Ensure that np.concatenate with dtype argument works on quantities and masked data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request ensures
np.concatenatewill work onQuantityandMaskedalso with thedtypeargument (new since numpy 1.20); see discussion in #13322 (but relevant not just for numpy-dev).Fixes #
Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
Extra CIlabel.no-changelog-entry-neededlabel. If this is a manual backport, use theskip-changelog-checkslabel unless special changelog handling is necessary.astropy-botcheck might be missing; do not let the green checkmark fool you.backport-X.Y.xlabel(s) before merge.