Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In astropy/utils/data.py, update _rmtree to use shutil.move instead of os.rename. #13730

Merged
merged 3 commits into from Apr 12, 2023
Merged

In astropy/utils/data.py, update _rmtree to use shutil.move instead of os.rename. #13730

merged 3 commits into from Apr 12, 2023

Commits on Apr 3, 2023

  1. In astropy/utils/data.py, update _rmtree to catch OSError and use `… 

    …`shutil.move`` if errno == EXDEV.

Using `os.rename` may raise an "OSError: [Errno 18] Invalid cross-device link" exception when running o a containairized environments deployed on kubernetes.
    @tribeiro
    tribeiro committed Apr 3, 2023
    Copy the full SHA
    ea490e1 View commit details
    Browse the repository at this point in the history

  2. Add tests for import_file_to_cache and clear_download_cache f… 

    …or when ``os.rename`` raises an OSError exception with ``errno = errno.EXDEV``.
    @tribeiro
    tribeiro committed Apr 3, 2023
    Copy the full SHA
    4fa8119 View commit details
    Browse the repository at this point in the history

  3. Update changelog.

    @tribeiro
    tribeiro committed Apr 3, 2023
    Copy the full SHA
    e5afb33 View commit details
    Browse the repository at this point in the history