Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in tile decompression #14649

Merged
merged 2 commits into from
Apr 19, 2023
Merged

Fix memory leak in tile decompression #14649

merged 2 commits into from
Apr 19, 2023

Conversation

saimn
Copy link
Contributor

@saimn saimn commented Apr 19, 2023

@saimn saimn added io.fits Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed labels Apr 19, 2023
@saimn saimn added this to the v5.3 milestone Apr 19, 2023
@astrofrog
Copy link
Member

Nice find! How did you track it down?

@github-actions
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim requested review from astrofrog and Cadair April 19, 2023 11:20
@pllim pllim added the Bug label Apr 19, 2023
@pllim pllim mentioned this pull request Apr 19, 2023
Merged
@saimn
Copy link
Contributor Author

saimn commented Apr 19, 2023

@astrofrog - Thanks to memray:
Screenshot from 2023-04-19 14-11-32

Cadair
Cadair approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@pllim pllim merged commit d1cf21c into astropy:main Apr 19, 2023
27 of 29 checks passed
@saimn saimn deleted the fits-compression-leak branch April 19, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadair Cadair Cadair approved these changes

@astrofrog astrofrog Awaiting requested review from astrofrog

Assignees
No one assigned
Labels
Affects-dev PRs and issues that do not impact an existing Astropy release Bug io.fits no-changelog-entry-needed
Projects
None yet
Milestone
v5.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@saimn @astrofrog @Cadair @pllim