Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IERS Earth rotation and leap second tables (v5.2.x) #14779

Merged
merged 3 commits into from
May 7, 2023

Conversation

pllim
Copy link
Member

@pllim pllim commented May 6, 2023

Description

This pull request is to manually update IERS data from the script because automated update cannot be backported. I notice that the filename has also changed in main. 🤷

As in #14778 , the diff seems excessive... +14,343 −14,262

@pllim

This comment was marked as resolved.

@pllim

This comment was marked as resolved.

@pllim
Copy link
Member Author

pllim commented May 6, 2023

I think the remaining failures are unrelated... 🤞

Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks all good. With hindsight, perhaps we should have backported #14382 after all... It is certainly annoying that essentially the whole file changed.

@pllim
Copy link
Member Author

pllim commented May 7, 2023

Thanks for the review and approval, @mhvk !

Re: Hindsight -- It was a tough call. There were API changes that turned out to be unnecessary after upstream reverted stuff. 🤷

@pllim pllim merged commit dec603c into astropy:v5.2.x May 7, 2023
22 of 23 checks passed
@pllim pllim deleted the update-iers-20230506-for-v5.2.x branch May 7, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants