Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Remove remote call to Danbury, CT #14807

Merged
merged 1 commit into from May 11, 2023

Conversation

pllim
Copy link
Member

@pllim pllim commented May 10, 2023

Description

This pull request is to remove remote call to Danbury, CT for EarthLocation.of_address() to reduce server hit.

I decided not to fix the failing example because I don't see much point in making extra queries when the text already says you can pass in partial address if you want. What the server actually can and cannot parse is beyond our control.

Original failure that started on 2023-05-09:

_____________________________ [doctest] index.rst ______________________________
341 For arbitrary Earth addresses (e.g., not observatory sites), use the
342 :meth:`~astropy.coordinates.EarthLocation.of_address` classmethod to retrieve
343 the latitude and longitude. This works with fully specified addresses, location
344 names, city names, etc:
345 
346 .. doctest-remote-data::
347 
348     >>> EarthLocation.of_address('1002 Holy Grail Court, St. Louis, MO')  # doctest: +FLOAT_CMP
349     <EarthLocation (-26769.86528679, -4997007.71191864, 3950273.57633915) m>
350     >>> EarthLocation.of_address('Danbury, CT')  # doctest: +FLOAT_CMP
Expected:
    <EarthLocation (1362610.66896362, -4590755.48088484, 4198817.69912853) m>
Got:
    <EarthLocation (1364606.6451165, -4593292.9428273, 4195415.93695139) m>

docs/coordinates/index.rst:350: DocTestFailure

for EarthLocation.of_address to reduce server hit
@pllim pllim added testing Docs no-changelog-entry-needed 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.2.x on-merge: backport to v5.2.x 💤 backport-v5.3.x on-merge: backport to v5.3.x labels May 10, 2023
@pllim pllim added this to the v5.0.7 milestone May 10, 2023
@pllim pllim requested review from adrn and eerovaher May 10, 2023 15:52
@github-actions
Copy link

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

This comment was marked as resolved.

@pllim pllim closed this May 10, 2023
@pllim pllim reopened this May 10, 2023
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@pllim

This comment was marked as resolved.

@pllim pllim closed this May 10, 2023
@pllim pllim reopened this May 10, 2023
@pllim pllim closed this May 10, 2023
@pllim pllim reopened this May 10, 2023
Copy link
Member

@adrn adrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me :) - that was just a silly easter egg of mine to inject my hometown into the examples, but I think the previous example is sufficient!

@pllim pllim closed this May 10, 2023
@pllim pllim reopened this May 10, 2023
@pllim

This comment was marked as resolved.

@pllim pllim closed this May 10, 2023
@pllim pllim reopened this May 10, 2023
@pllim

This comment was marked as resolved.

@pllim pllim closed this May 11, 2023
@pllim pllim reopened this May 11, 2023
@adrn
Copy link
Member

adrn commented May 11, 2023

image

@mhvk
Copy link
Contributor

mhvk commented May 11, 2023

OK, finally all tests seem to have passed -- merging!

@mhvk mhvk merged commit cc73b24 into astropy:main May 11, 2023
30 of 31 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request May 11, 2023
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request May 11, 2023
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request May 11, 2023
@pllim pllim deleted the why-did-they-move-danbury branch May 11, 2023 13:21
pllim added a commit that referenced this pull request May 11, 2023
…807-on-v5.0.x

Backport PR #14807 on branch v5.0.x (TST: Remove remote call to Danbury, CT)
pllim added a commit that referenced this pull request May 15, 2023
…807-on-v5.3.x

Backport PR #14807 on branch v5.3.x (TST: Remove remote call to Danbury, CT)
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request May 16, 2023
…f-pr-14807-on-v5.2.x

Backport PR astropy#14807 on branch v5.2.x (TST: Remove remote call to Danbury, CT)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coordinates Docs no-changelog-entry-needed testing 💤 backport-v5.0.x on-merge: backport to v5.0.x 💤 backport-v5.2.x on-merge: backport to v5.2.x 💤 backport-v5.3.x on-merge: backport to v5.3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants