New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Remove remote call to Danbury, CT #14807
Conversation
for EarthLocation.of_address to reduce server hit
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me :) - that was just a silly easter egg of mine to inject my hometown into the examples, but I think the previous example is sufficient!
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
OK, finally all tests seem to have passed -- merging! |
…807-on-v5.0.x Backport PR #14807 on branch v5.0.x (TST: Remove remote call to Danbury, CT)
…807-on-v5.3.x Backport PR #14807 on branch v5.3.x (TST: Remove remote call to Danbury, CT)
…f-pr-14807-on-v5.2.x Backport PR astropy#14807 on branch v5.2.x (TST: Remove remote call to Danbury, CT)
Description
This pull request is to remove remote call to Danbury, CT for
EarthLocation.of_address()
to reduce server hit.I decided not to fix the failing example because I don't see much point in making extra queries when the text already says you can pass in partial address if you want. What the server actually can and cannot parse is beyond our control.
Original failure that started on 2023-05-09: