Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TimeDelta format quantity_str for Year Day Hour Minute Sec string #15264

Merged
merged 24 commits into from
Oct 19, 2023
Merged

Add TimeDelta format quantity_str for Year Day Hour Minute Sec string #15264

merged 24 commits into from
Oct 19, 2023

Commits on Oct 17, 2023

  1. Change TimeBase logic for handling format 

    This now relies entirely on being a subclass of TimeUnique
instead of also checking on input datatype. This is needed to
allow `jd` as a unique format for TimeDelta.
    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    9721ee8 View commit details
    Browse the repository at this point in the history

  2. Add TimeDelta format for Year Day Hour Minute Sec string

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    082470d View commit details
    Browse the repository at this point in the history

  3. Allow precision, in_subfmt, out_subfmt in TimeDelta init 

    This is an API change since the final copy arg position changed. To make this clear args after scale are now required
as keyword args.
    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    586b9df View commit details
    Browse the repository at this point in the history

  4. Support multi-component and specific units as subfmts

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    8a586e6 View commit details
    Browse the repository at this point in the history

  5. Improve exception with no match for format 

    There is no good reason to raise from the first format
exception since that one is not necessarily the culprit.
    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    5cd79b7 View commit details
    Browse the repository at this point in the history

  6. Require matching entire string in regex

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    330333f View commit details
    Browse the repository at this point in the history

  7. Fix test and docstrings

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    cb1292d View commit details
    Browse the repository at this point in the history

  8. Improve logic for detecting numeric input without unit

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    87fda10 View commit details
    Browse the repository at this point in the history

  9. Remove leading "+" in output

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    7d77bdc View commit details
    Browse the repository at this point in the history

  10. Expand format docstring substantially [ci skip]

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    008c0ea View commit details
    Browse the repository at this point in the history

  11. Fix check_numeric_no_unit [ci skip]

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    d22299e View commit details
    Browse the repository at this point in the history

  12. WIP narrative docs update

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    421d57c View commit details
    Browse the repository at this point in the history

  13. Fix unused import after rebase

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    2124ff8 View commit details
    Browse the repository at this point in the history

  14. Fix quantity_str regex

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    601c933 View commit details
    Browse the repository at this point in the history

  15. Add tests of quantity_str

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    6cb1bc5 View commit details
    Browse the repository at this point in the history

  16. Add another test

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    8097bd8 View commit details
    Browse the repository at this point in the history

  17. Add What's New section

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ac41ad0 View commit details
    Browse the repository at this point in the history

  18. Add change log entry

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    fd3ee9f View commit details
    Browse the repository at this point in the history

  19. Implement review suggestions to improve precision

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    1c411d6 View commit details
    Browse the repository at this point in the history

  20. Factor out hardwired Time precision=3 into Format class attributes

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ed7ddbb View commit details
    Browse the repository at this point in the history

  21. Remove yr from multi and fix overflows

    @taldcroft
    taldcroft committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    f07ade2 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Minor cleanup, API changelog, fix coverage

    @taldcroft
    taldcroft committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    d7c0d42 View commit details
    Browse the repository at this point in the history

  2. Fix a few more CI issues

    @taldcroft
    taldcroft committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    1e86efa View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Final review tweaks

    @taldcroft
    taldcroft committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    d8968b2 View commit details
    Browse the repository at this point in the history