Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport PR #15286 on branch main (Finalizing changelog for v5.3.3) #15287

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Backport PR #15286 on branch main (Finalizing changelog for v5.3.3) #15287

merged 1 commit into from
Sep 7, 2023

Conversation

meeseeksmachine
Copy link

Backport PR #15286: Finalizing changelog for v5.3.3

@lumberbot-app lumberbot-app bot added this to the v5.3.3 milestone Sep 7, 2023
@lumberbot-app lumberbot-app bot added units Release modeling cosmology skip-changelog-checks Tells bot to skip changlog checks skip-basebranch-check Skip base branch check for direct backports backport-main on-merge: backport to main labels Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim modified the milestones: v5.3.3, v6.0 Sep 7, 2023
@pllim pllim removed the skip-basebranch-check Skip base branch check for direct backports label Sep 7, 2023
@pllim pllim enabled auto-merge September 7, 2023 13:22
@pllim pllim merged commit bc0be28 into astropy:main Sep 7, 2023
26 of 28 checks passed
@lumberbot-app
Copy link

lumberbot-app bot commented Sep 7, 2023

Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out.

@pllim
Copy link
Member

pllim commented Sep 7, 2023

LoL ooops maybe should have removed the backport label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

Assignees
No one assigned
Labels
backport-main on-merge: backport to main cosmology modeling Release skip-changelog-checks Tells bot to skip changlog checks units
Projects
Cosmology, the Expansion
Status: Done
Milestone
v6.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meeseeksmachine @pllim @astrofrog