Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalizing changelog for v5.3.4 #15424

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Finalizing changelog for v5.3.4 #15424

merged 1 commit into from
Oct 4, 2023

Conversation

saimn
Copy link
Contributor

@saimn saimn commented Oct 3, 2023

Description

This pull request is to address ...

Fixes #

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@saimn saimn added no-changelog-entry-needed Extra CI Run cron CI as part of PR Build all wheels Run all the wheel builds rather than just a selection labels Oct 3, 2023
@saimn saimn added this to the v5.3.4 milestone Oct 3, 2023
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see "When to rebase and squash commits".
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

pllim
pllim approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim added the skip-basebranch-check Skip base branch check for direct backports label Oct 3, 2023
@pllim
Copy link
Member

pllim commented Oct 3, 2023

Gonna close/reopen for bot

@pllim pllim closed this Oct 3, 2023
@pllim pllim reopened this Oct 3, 2023
@pllim pllim added the skip-changelog-checks Tells bot to skip changlog checks label Oct 3, 2023
@saimn saimn merged commit 110b78e into astropy:v5.3.x Oct 4, 2023
97 of 119 checks passed
@saimn saimn deleted the v5.3-changelog branch October 4, 2023 16:42
@pllim
Copy link
Member

pllim commented Oct 4, 2023

Does this need to be forward-ported?

@saimn
Copy link
Contributor Author

saimn commented Oct 4, 2023

yes, but I'm waiting for the wheels to be built and uploaded, to be sure the release is done.

@saimn
Copy link
Contributor Author

saimn commented Oct 4, 2023

@meeseeksdev backport to main

@meeseeksmachine meeseeksmachine mentioned this pull request Oct 4, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/astropy that referenced this pull request Oct 4, 2023
@saimn @meeseeksmachine
Backport PR astropy#15424: Finalizing changelog for v5.3.4
bf24d59
saimn added a commit that referenced this pull request Oct 4, 2023
@saimn
Merge pull request #15430 from meeseeksmachine/auto-backport-of-pr-15…
2ad7454 
…424-on-main

Backport PR #15424 on branch main (Finalizing changelog for v5.3.4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pllim pllim pllim approved these changes

Assignees
No one assigned
Labels
Build all wheels Run all the wheel builds rather than just a selection Extra CI Run cron CI as part of PR no-changelog-entry-needed skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks units utils
Projects
None yet
Milestone
v5.3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saimn @pllim