Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure BaseCoordinateFrame separation methods work with SkyCoord input #15659

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Ensure BaseCoordinateFrame separation methods work with SkyCoord input #15659

merged 2 commits into from
Dec 4, 2023

Commits on Nov 30, 2023

  1. Add a test for BaseCoordinateFrame separations 

    The new test reveals that the `BaseCoordinateFrame` methods
`separation()` and `separation_3d()` can produce incorrect results if
their argument is a `SkyCoord` instance. The methods do not claim to
support `SkyCoord` input, but the current behaviour is nonetheless
dangerous and should be considered to be a bug.
    @eerovaher
    eerovaher committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    e5cd0a2 View commit details
    Browse the repository at this point in the history

  2. Fix BaseCoordinateFrame separations with SkyCoord 

    The `BaseCoordinateFrame` `separation()` and `separation_3d()` methods
can now safely be used with `SkyCoord` instances as inputs.
    @eerovaher
    eerovaher committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    4f9bab5 View commit details
    Browse the repository at this point in the history