Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[io.ascii.cds] Find "Explanations" position to identify continuation lines in Readme from column headings #15731

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhomeier
Copy link
Contributor

Description

Follow-up to #15617 – this implements the approach described in #15617 (comment) to strip header lines just to the position before the start of the Explanations column, allowing the parser to automatically identify and merge continuation lines.

To be discussed if this

  1. needs an extra test
  2. should do a case-insensitive search for explanation
  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@dhomeier dhomeier added io.ascii Bug 💤 backport-v6.0.x on-merge: backport to v6.0.x labels Dec 13, 2023
@dhomeier dhomeier added this to the v6.0.1 milestone Dec 13, 2023
@saimn saimn modified the milestones: v6.0.1, v6.0.2 Mar 25, 2024
@astrofrog astrofrog modified the milestones: v6.0.2, v6.1.1 Apr 4, 2024
@pllim pllim added backport-v6.1.x on-merge: backport to v6.1.x and removed 💤 backport-v6.0.x on-merge: backport to v6.0.x labels May 6, 2024
Copy link

Hi humans 👋 - this pull request hasn't had any new commits for approximately 4 months. I plan to close this in 30 days if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future. Maintainers may also choose to add keep-open label to keep this PR open but it is discouraged unless absolutely necessary.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants