-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: known issue about pandas Series multiplication #15904
Conversation
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Hmm, this is failing as pandas isn't installed in the minimal dependencies environment and in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the test failure, there is
.. doctest-requires:: pandas
but I'm not sure we can give this a minimum version.
To be honest, I'm fine with just skipping the tests...
Co-authored-by: Eero Vaher <eero.vaher@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @MridulS! Looks all good to me, but I'll let @eerovaher have a last look too.
Co-authored-by: Eero Vaher <eero.vaher@gmail.com>
This is almost ready, but there's a trailing whitespace somewhere that is causing the |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@eerovaher , the bot took care of the trailing whitespace. Does this look good to you now? We can always use the squash and merge button for this PR. Thanks, all! |
…904-on-v6.0.x Backport PR #15904 on branch v6.0.x (DOC: known issue about pandas Series multiplication)
Description
This PR adds a section to https://docs.astropy.org/en/latest/known_issues.html regarding the fragile behavior with pd.Series objects.
Fixes #11247