Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten _get_frame_without_data() #16137

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

eerovaher
Copy link
Member

@eerovaher eerovaher commented Mar 1, 2024

Description

The rewritten function is shorter and also less indented, so ignoring indentation-only changes can be helpful for reviewing:

$ git diff --stat --ignore-space-change main 
 astropy/coordinates/sky_coordinate_parsers.py | 70 +++++++++++++++++---------------------------------
 1 file changed, 24 insertions(+), 46 deletions(-)
  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

Copy link

github-actions bot commented Mar 1, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good simplification. I have just one further suggestion (but fine to ignore).

astropy/coordinates/sky_coordinate_parsers.py Show resolved Hide resolved
@eerovaher eerovaher force-pushed the shorten_get_frame_without_data branch from 502e786 to 8626d92 Compare March 1, 2024 19:17
@eerovaher eerovaher requested a review from mhvk March 1, 2024 19:22
Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get it in...

@mhvk mhvk merged commit 6796cb3 into astropy:main Mar 1, 2024
24 of 27 checks passed
@eerovaher eerovaher deleted the shorten_get_frame_without_data branch March 1, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants