Pass character_as_bytes when converting Table to BinTableHDU

[saimn]

Fix issue reported on Slack:

In [2]: tbl = astropy.table.Table({"NAME": ["foo", "bar"]})

In [3]: fits.BinTableHDU(tbl, character_as_bytes=True).data['NAME']  # DOESN'T WORK
Out[3]: chararray(['foo', 'bar'], dtype='<U3')

In [4]: fits.table_to_hdu(tbl, character_as_bytes=True).data['NAME']  # WORKS
Out[4]: chararray([b'foo', b'bar'], dtype='|S3')

Description

This pull request is to address ...

Fixes #

• By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

[github-actions]

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

[olebole]

Whow! That is quick! For me, this looks good, approving w/o any requested changes. Thank you very much for the fix.

[pllim]

Thanks, all!