Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NEP 29 with SPEC 0 #16376

Closed
wants to merge 1 commit into from
Closed

Conversation

bnavigator
Copy link
Contributor

Description

NEP 29 has been superseded by SPEC 0.

@github-actions github-actions bot added the Docs label May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim added this to the v7.0.0 milestone May 3, 2024
@pllim pllim modified the milestones: v7.0.0, v6.1.0 May 3, 2024
@pllim pllim added the backport-v6.1.x on-merge: backport to v6.1.x label May 3, 2024
@pllim pllim requested a review from a team May 3, 2024 14:14
@pllim
Copy link
Member

pllim commented May 3, 2024

Might be a bit too late to modify v6.1 What's New now as @astrofrog is about to release v6.1 already. Also, I think this is more of an update to https://github.com/astropy/astropy-APEs/blob/main/APE18.rst rather than this repo?

@pllim pllim added skip-basebranch-check Skip base branch check for direct backports and removed backport-v6.1.x on-merge: backport to v6.1.x labels May 3, 2024
@pllim
Copy link
Member

pllim commented May 3, 2024

I opened this issue over at the APEs repo. Let's discuss there instead. Thanks!

@pllim pllim closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs no-changelog-entry-needed skip-basebranch-check Skip base branch check for direct backports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants