Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: fix compatibility with numpy 2 (copy semantics) in a coordinates test #16385

Merged

Conversation

neutrinoceros
Copy link
Contributor

Description

Follow up to #16166
I missed this test in my previous PRs because I didn't have jplephem installed. This was caught in today's daily cron.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros force-pushed the coordinates/compat/test/numpy2_compat branch from 9ae4b29 to 2ec124b Compare May 5, 2024 09:10
Copy link

github-actions bot commented May 5, 2024

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if that's all you missed - pretty good! Let's get it in.

@mhvk mhvk modified the milestones: v6.1.0, v6.1.1 May 5, 2024
@mhvk mhvk merged commit 4a9a025 into astropy:main May 5, 2024
39 of 44 checks passed
@neutrinoceros
Copy link
Contributor Author

@mhvk I don't see a backport PR for this. Can you ping the bot here ? (I assume I don't have rights to do it myself)

@neutrinoceros neutrinoceros deleted the coordinates/compat/test/numpy2_compat branch May 5, 2024 19:46
@mhvk
Copy link
Contributor

mhvk commented May 5, 2024

@meeseeksdev backport to 6.0.x

Copy link

lumberbot-app bot commented May 5, 2024

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@mhvk
Copy link
Contributor

mhvk commented May 5, 2024

@meeseeksdev backport to 6.1.x

Copy link

lumberbot-app bot commented May 5, 2024

Something went wrong ... Please have a look at my logs.

It seems that the branch you are trying to backport to does not exist.

@mhvk
Copy link
Contributor

mhvk commented May 5, 2024

I think I forgot the incantation... Of course, the real problem is that I forgot to set the label...

@mhvk
Copy link
Contributor

mhvk commented May 5, 2024

@meeseeksdev backport to v6.1.x

@mhvk
Copy link
Contributor

mhvk commented May 5, 2024

Arrgghh, just forgot a "v". But now it is done at least.

mhvk added a commit that referenced this pull request May 6, 2024
…385-on-v6.1.x

Backport PR #16385 on branch v6.1.x (TST: fix compatibility with numpy 2 (copy semantics) in a coordinates test)
@neutrinoceros
Copy link
Contributor Author

Thank you !

@pllim pllim added the backport-v6.1.x on-merge: backport to v6.1.x label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants