[pre-commit.ci] pre-commit autoupdate

[pre-commit-ci]

updates:

• github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0
• github.com/astral-sh/ruff-pre-commit: v0.3.4 → v0.4.3
• github.com/scientific-python/cookie: 2024.01.24 → 2024.04.23

[github-actions]

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

• Do the proposed changes actually accomplish desired goals?
• Do the proposed changes follow the Astropy coding guidelines?
• Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
• Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
• Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
• Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
• Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
• Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
• At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

[nstarman]

Let's update the pre-commit config so that these PRs include the recommended steps to fix a failing PR. Currently our practice is to close this PR, cherry-pick the commits into a new PR where we fix whatever's wrong. This is because the Pre-commit PRs are branches on Astropy main, not from a fork. Let's record this institutional knowledge into the PR message itself.

[pllim]

I don't think this change should happen, right?

[nstarman]

No, this is ruff trying to fix our code for v2, but we don't want that in this specific case.

[pllim]

Yeah... let's close and PR from fork.

ruff.....................................................................Failed
- hook id: ruff
- exit code: 1

astropy/io/fits/header.py:1072:21: UP031 Use format specifiers instead of percent format
Found 1 error.