Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wcs setter to ccddata.py #247

Closed
wants to merge 2 commits into from
Closed

Conversation

stottsco
Copy link
Contributor

Edit: Closes #203

@mwcraig
Copy link
Member

mwcraig commented Oct 24, 2015

@stottsco -- thanks for the pull request!

Two comments:

  • Could you please add a test for your fix? Email me or wait til or regular meeting if you need help with that.
  • I don't think you need to define the wcs property getter, just need the setter (one of the superclasses of CCDData already defines the getter). I might be wrong though...

To update your PR, make the changes locally, commit them, then push to your branch on github.

@bsipocz
Copy link
Member

bsipocz commented Nov 10, 2015

@stottsco - Could you please rebase this as travis is not stating up properly (due to an independent change in conda; this has been addressed in master since).

@mwcraig
Copy link
Member

mwcraig commented Nov 19, 2015

Superseded by #256

@mwcraig mwcraig closed this Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants