Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Revise [docs only] for repos that use circleCI for their docs build #417

Closed
bsipocz opened this issue Sep 17, 2019 · 8 comments
Closed

Revise [docs only] for repos that use circleCI for their docs build #417

bsipocz opened this issue Sep 17, 2019 · 8 comments

Comments

@bsipocz
Copy link
Member

bsipocz commented Sep 17, 2019

Jobs shouldn't be run tests here:
https://travis-ci.org/astropy/astropy/builds/586132358?utm_source=github_status&utm_medium=notification

Also, now that many projects are moving their docs builds to circleCI from travis, [docs only] could be made a bit more clever, e.g. if there isn't even one docs job in the travis config the hole build should be cancelled without going into the individual jobs.

@pllim
Copy link
Member

pllim commented Sep 17, 2019

Yeah, something like not right with this logic somehow but my bash-fu is not strong enough...

elif [[ ! -z $(echo ${COMMIT_MESSAGE} | grep -E "${DOCS_ONLY}") ]]; then
if ! [[ $SETUP_CMD =~ build_docs|build_sphinx|pycodestyle|flake8|pep8 ]] && [[ MAIN_CMD =~ pycodestyle|flake8|pep8 ]]; then
# we also allow the style checkers to run here
echo "Only docs build was requested by the commit message, exiting."
travis_terminate 0
fi

It looks as if [docs only] has no effect now; i.e., all the Travis jobs run regardless.

@pllim
Copy link
Member

pllim commented Sep 17, 2019

Maybe I broke it in #407 . 😭

@pllim
Copy link
Member

pllim commented Oct 15, 2019

I think this is now fixed?

@pllim
Copy link
Member

pllim commented Oct 15, 2019

Oh, wait... Haven't done "if there isn't even one docs job in the travis config the hole build should be cancelled without going into the individual jobs"... BUT do we really want that? I thought we still want PEP 8 job to run regardless.

@bsipocz
Copy link
Member Author

bsipocz commented Oct 15, 2019

There is a pep8 test on circleCI now, too, so it's all good to cancel the whole of travis.

@pllim
Copy link
Member

pllim commented Oct 15, 2019

But, only the core does that, not everyone else who uses ci-helpers?

@bsipocz
Copy link
Member Author

bsipocz commented Oct 15, 2019

oh, yes, you're right regarding that.

@pllim
Copy link
Member

pllim commented Oct 15, 2019

Maybe the title of the issue should at least be updated, as [docs only] is no longer broken.

@bsipocz bsipocz changed the title [docs only] is broken Revise [docs only] for repos that use circleCI for their docs build Oct 15, 2019
@bsipocz bsipocz added the wontfix label Nov 1, 2021
@bsipocz bsipocz closed this as completed Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants