Keeping order of installs #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsipocz
force-pushed
the
travis_install_order
branch
from
b8a5792
to
9ab940d
Compare
| # We then install Numpy itself at the bottom of this script | ||
| export CONDA_INSTALL="conda install $QUIET python=$PYTHON_VERSION" | ||
| elif [[ $NUMPY_VERSION == stable ]]; then | ||
| conda install $QUIET numpy=$LATEST_NUMPY_STABLE | ||
| conda install $QUIET --no-pin numpy=$LATEST_NUMPY_STABLE |
There was a problem hiding this comment.
Will it not be the case that when installing the main dependencies later, there will still be the issue that the pin file can contain numpy stable*?
There was a problem hiding this comment.
yes, probably you're right, I'll look at this again.
There was a problem hiding this comment.
No, numpy isn't listed in the pinfile, e.g. for a NUMPY_VERSION=stable CONDA_DEPENDENCIES='jinja2=2.8' build, the pinfile contains only jinja:
++++cat /home/travis/miniconda/envs/test/conda-meta/pinned
jinja2 2.8*
There was a problem hiding this comment.
Do you think it's better to pin down the numpy version, too?
bsipocz
force-pushed
the
travis_install_order
branch
from
9ab940d
to
dec42fd
Compare
…he conda dependencies in the numpy and astropy steps
bsipocz
force-pushed
the
travis_install_order
branch
from
dec42fd
to
bf7e924
Compare
|
I'm merging this now, if there is a problem coming up we can still pin the numpy version, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to address #123.
Not sure how it can be tested, but e.g. in the prerelease travis test, scipy now shouldn't be installed even though it's listed in CONDA_DEPENDENCIES.
If this works, I'll add more commits to deal with the astropy step.