Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Make sure version pinning works for numpy and astropy when in CONDA_DEPENDENCIES #84

Closed
bsipocz opened this issue May 18, 2016 · 8 comments

Comments

@bsipocz
Copy link
Member

bsipocz commented May 18, 2016

They are not designed to be listed in CONDA_DEPENDENCIES and if one of the string versions were used in e.g. ASTROPY_VERSION, the version pinning fails the build.

This issue came up with Chandra-MARX/marxs#62, here is a travis log snippet:

++++CONDA_DEPENDENCIES='numpy scipy astropy cffi sphinx matplotlib'

++++[[ True == True ]]

++++cat /home/travis/miniconda/envs/test/conda-meta/pinned

numpy stable*

scipy

astropy stable*

cffi

sphinx

matplotlib

++++echo numpy scipy astropy cffi sphinx matplotlib

numpy scipy astropy cffi sphinx matplotlib

++++[[ stable == dev* ]]

++++[[ stable == stable ]]

++++conda install numpy

Fetching package metadata: ..........

Solving package specifications: .

Error:  Packages missing in current linux-64 channels: 

  - numpy stable*

  - astropy stable*
@astrofrog
Copy link
Member

In the spirit of making ci-helpers more general for other packages, I think it should be fine to list astropy and numpy in CONDA_DEPENDENCIES, and I think in this case it might just be a matter of ignoring 'stable' in any pinning since it's equivalent to not pinning?

@astrofrog
Copy link
Member

Ah but that won't work for dev - I see why it makes sense to not list them in CONDA_DEPENDENCIES

@bsipocz
Copy link
Member Author

bsipocz commented Sep 2, 2016

yes, and we already do that. Or I remember making this fix at some point.

@bsipocz
Copy link
Member Author

bsipocz commented Sep 2, 2016

Oh, it's not merged yet, #124
Would you take a look at it whether it makes sense?

@bsipocz
Copy link
Member Author

bsipocz commented May 30, 2017

@cdeil run into this issue again in hipspy/hips#6

@astrofrog
Copy link
Member

I ran into this again. I think that we should simply strip numpy and astropy out of CONDA_DEPENDENCIES if they are specified accidentally.

@bsipocz
Copy link
Member Author

bsipocz commented Jul 13, 2017

@astrofrog - sounds good. I don't have time this week to do any work on ci-helpers, but there are a few open issues I would rather see solved soon, so probably next week I can cook up a few fixes.

@astrofrog
Copy link
Member

@bsipocz - great! This is not really urgent though, so don't worry too much if you don't have time :)

@bsipocz bsipocz added the wontfix label Nov 1, 2021
@bsipocz bsipocz closed this as completed Nov 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants