-
-
Notifications
You must be signed in to change notification settings - Fork 34
Make sure version pinning works for numpy and astropy when in CONDA_DEPENDENCIES #84
Comments
In the spirit of making ci-helpers more general for other packages, I think it should be fine to list astropy and numpy in CONDA_DEPENDENCIES, and I think in this case it might just be a matter of ignoring 'stable' in any pinning since it's equivalent to not pinning? |
Ah but that won't work for dev - I see why it makes sense to not list them in CONDA_DEPENDENCIES |
yes, and we already do that. Or I remember making this fix at some point. |
Oh, it's not merged yet, #124 |
@cdeil run into this issue again in hipspy/hips#6 |
I ran into this again. I think that we should simply strip numpy and astropy out of CONDA_DEPENDENCIES if they are specified accidentally. |
@astrofrog - sounds good. I don't have time this week to do any work on ci-helpers, but there are a few open issues I would rather see solved soon, so probably next week I can cook up a few fixes. |
@bsipocz - great! This is not really urgent though, so don't worry too much if you don't have time :) |
They are not designed to be listed in
CONDA_DEPENDENCIES
and if one of the string versions were used in e.g.ASTROPY_VERSION
, the version pinning fails the build.This issue came up with Chandra-MARX/marxs#62, here is a travis log snippet:
The text was updated successfully, but these errors were encountered: