Support setup.py test --coverage
in affiliated packages.
#39
Conversation
@@ -11,6 +11,8 @@ __pycache__ | |||
|
|||
# Other generated files | |||
*/version.py | |||
htmlcov | |||
.coverage | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a .coverage automatically created or why is it excluded here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. setup.py test --coverage
will store its coverage data in .coverage
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry brain fart - I read .coveragerc
.
Support `setup.py test --coverage` in affiliated packages.
@astrofrog I think it would be a good idea to send an email to In this case maybe not everyone wants it, but e.g. I am seeing this warning and don't have time to investigate what has changed and what I should do to fix it:
|
@cdeil - I agree about emailing astropy-dev. It'd be really helpful if someone else could start being responsible for maintaining, updating, advertising etc. the package-template since it's a fair bit of work to stay on top of things. If you'd be interested in taking charge of this, then let me know :) For this change, I didn't advertise it because it's not critical and also because there will be other changes coming soon (setup and configuration) so I figured we might just want to do a sprint and update all the affiliated packages once that's all done. Assuming an affiliated package started from the package-template, it's easy to just pull from the package-template remote and merge the changes into an existing affiliated package. |
As @astrofrog said, since this is git, it's always possible to see what has changed in the upstream package-template and merge those changes in. It won't do the renaming of values within the files for you, of course, but I have some thoughts about how to make that easier on affiliated packages -- I just haven't had the time to really dive into it. |
Fixes #25. Requires astropy/astropy#2132.