Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbose mode in elliptical isophote fitting #823

Closed
ibusko opened this issue Apr 11, 2019 · 7 comments
Closed

Verbose mode in elliptical isophote fitting #823

ibusko opened this issue Apr 11, 2019 · 7 comments

Comments

@ibusko
Copy link
Contributor

ibusko commented Apr 11, 2019

Elliptical isophote fitting can be slow, depending on the size of the galaxy being fitted. Even relatively small images as provided in the tutorials in photoutils-datasets take tens of seconds to complete. In the meantime, no feedback is sent back to the user that sits waiting, thinking that maybe the code is frozen in an infinite loop. This situation seems even more disconcerting when running the method from a Jupyter notebook, since no command line prompt or anything else shows up. The notebook just looks frozen.

To partially fix that situation, the fitting loop provided in method fit_image in class Ellipse used to have a verbose mode that would print at the terminal a line with fitting results for evey completed ellipse fitted. The option is no longer available though. It should be put back in place to minimize user confusion.

This may be re-addressed once a speed-up of the code can be put in place, as suggested in issue #802.

@ibusko
Copy link
Contributor Author

ibusko commented Aug 5, 2019

@larrybradley are you cool with this? I have some available time for coding now, and I could add back the verbose feature as an optional keyword parameter with minimal work.

@moustakas
Copy link

This is a separate issue, but another related feature request would be to (optionally) speed up the fit_image method using the multiprocessing module, assuming each semimajor axis can be fitted independently.

@larrybradley
Copy link
Member

@ibusko Reporting progress is fine with me, but please leave the final output in an Astropy Table. Thanks.

@larrybradley
Copy link
Member

@moustakas Can you please open a new issue with your feature request so it doesn't get lost (i.e. when this issue is closed)?

@ibusko
Copy link
Contributor Author

ibusko commented Aug 5, 2019

@larrybradley sure. I envision 'verbose' mode as just help for more tricky situations. The main output will still be the astropy Table that's already there. 'verbose' by default will be off as well, so it won't affect existing user scripts and the like.

@ibusko
Copy link
Contributor Author

ibusko commented Aug 14, 2019

This relates to #891

@larrybradley
Copy link
Member

Verbose mode was added in #947.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants