Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set client-side defaults for SIA query params #366

Closed
tomdonaldson opened this issue Sep 29, 2022 · 1 comment · Fixed by #367
Closed

Don't set client-side defaults for SIA query params #366

tomdonaldson opened this issue Sep 29, 2022 · 1 comment · Fixed by #367

Comments

@tomdonaldson
Copy link
Contributor

tomdonaldson commented Sep 29, 2022

The convenience search() functions for the sia module and the SIAService class specify default values for format,intersect and verbosity.

Although these defaults should not cause a problem with standard-compliant services, they are unnecessary and remove the client's ability to not specify those parameters to non-compliant services that may choke on specified values.

This use of defaults probably shows up for other dal modules, but this issue is focused on sia.

@tomdonaldson tomdonaldson changed the title Don Don't set client-side defaults for SIA query params Sep 29, 2022
@tomdonaldson tomdonaldson added this to the v1.4.1 milestone Sep 29, 2022
@tomdonaldson
Copy link
Contributor Author

This came up regarding the attempted use of a registered SIA service that fails when the client specified a format value, so this change would enable the easy work around of not specifying a format value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants