Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tj taprecord session #447

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Tj taprecord session #447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e9add0
Fixing TAPRecord to inherit session information
trjaffe May 22, 2023
611a885
Changelog
trjaffe May 22, 2023
d8ef6e4
DOC: move changelog to 1.4.2
bsipocz Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@
- Fix poor polling behavior when running an async query against a
TAP v1.1 service with unsupported WAIT parameter. [#440]

1.4.2 (unreleased)
==================

- Fixed TapResults to inherit session. [#447]

1.4.1 (2023-03-07)
==================
Expand Down Expand Up @@ -60,7 +64,7 @@

- pyvo.dal warns on results with overflow status. [#329]

- Allow session to be passed through in SSA and DataLink. [#327]
- Allow session to be passed through in SSA, SCR, and DataLink. [#327]

- pyvo.dal.tap.AsyncTAPJob treats parameter names as case-insensitive when
retrieving the query from the job record. [#357]
Expand Down
2 changes: 1 addition & 1 deletion pyvo/dal/tap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1179,7 +1179,7 @@ def getrecord(self, index):
--------
Record
"""
return TAPRecord(self, index)
return TAPRecord(self, index, session=self._session)


class TAPRecord(SodaRecordMixin, DatalinkRecordMixin, Record):
Expand Down