Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'all' and 'any' models from to_mask API? #72

Closed
astrofrog opened this issue Nov 8, 2016 · 5 comments
Closed

Remove 'all' and 'any' models from to_mask API? #72

astrofrog opened this issue Nov 8, 2016 · 5 comments
Milestone
0.2

Comments

@astrofrog
Copy link
Member

The 'all' and 'any' modes are maybe not needed - one can just use 'exact' and check the result compared to 0 and 1. In fact, this is hard to implement internally because for 'all', the exact mode can sometimes give results are are extremely close but not exactly 1 - so then we have to introduce a tolerance, which gets messy. I'd actually vote to remove these modes and just keep 'center', 'subpixels', and 'exact'. What do others think?
@larrybradley
Copy link
Member

Sounds good to me!

@cdeil
Copy link
Member

cdeil commented Nov 8, 2016

+1

@astrofrog
Copy link
Member Author

I've done that in #71, but will leave this open in case anyone else has objections

@bsipocz
Copy link
Member

bsipocz commented Nov 8, 2016

👍

@astrofrog astrofrog mentioned this issue Nov 8, 2016
Merged
@astrofrog
Copy link
Member Author

Done in #71

@cdeil cdeil added this to the 0.2 milestone Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2
Development

No branches or pull requests
4 participants
@astrofrog @cdeil @larrybradley @bsipocz