Add testing on Python 3.12 #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #399 +/- ##
=======================================
Coverage 93.60% 93.60%
=======================================
Files 25 25
Lines 891 891
=======================================
Hits 834 834
Misses 57 57 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dstansby
force-pushed
the
main
branch
2 times, most recently
from
4df4501
to
7267bfb
Compare
dstansby
changed the title
|
Sorry I accidentally pushed these commits to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can get this building locally fine on Python 3.12 (using
python -m build), but can reproduce the tox failure. so I think the issue must be somehowtoxis installing a different and older version ofCythonwhen trying to buildreproject. I'm a bit lost on how to debug that though...Update: if I remove
aiohttpfrom the deps (that is also trying and failing to build a wheel due to Cython issues) this works fine. So I guess there's some dogy Cython version interaction going on somewhere... I think the answer here is to wait foraiohttpto get a new version out with 3.12 support and hopefully this will Just Work ™️ after that.