Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new README.rst #116

Merged
merged 4 commits into from
Apr 7, 2015
Merged

new README.rst #116

merged 4 commits into from
Apr 7, 2015

Conversation

dinosk
Copy link

@dinosk dinosk commented Mar 19, 2015

Hey @wkerzendorf, I made a summary from http://specutils.readthedocs.org/en/latest/specutils/index.html
Let me know if I should add or change something

@keflavich
Copy link
Contributor

There are some formatting issues in the .rst. Make sure to compile the rst to examine it; you can do this with github or with the rst2html.py script (I think it comes with docutils)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.56% when pulling a77c753 on dinossimpson:READMErst into a726cb0 on astropy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.56% when pulling a77c753 on dinossimpson:READMErst into a726cb0 on astropy:master.

@dinosk
Copy link
Author

dinosk commented Mar 25, 2015

Hey @wkerzendorf, I pushed the new index.rst file and created a pyplots directory where I put the plotting example. Waiting for feedback


For more information about the Spectrum1d object go to `Spectrum 1D`_.

Another common WCS is the **linear dispersion** and commonly serialized (encoded) to FITS keyword headers. For linear dispersion we are using the general `Spectrum1DPolynomialWCS`_ WCS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to note somewhere which keywords are required for Spectrum1DPolynomialWCS to be successfully read. Is that in the docs anywhere you can link to?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spectrum1DPolynomialWCS has no link to keywords it can be equally likely be initialized from a fit to an ascii table. The FITSHeader class does that.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.56% when pulling 43bb416 on dinossimpson:READMErst into a726cb0 on astropy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.56% when pulling 43bb416 on dinossimpson:READMErst into a726cb0 on astropy:master.

@wkerzendorf
Copy link
Member

This looks very nice!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.56% when pulling efb57b5 on dinossimpson:READMErst into a726cb0 on astropy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.56% when pulling ddf08f9 on dinossimpson:READMErst into a726cb0 on astropy:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.56% when pulling ddf08f9 on dinossimpson:READMErst into a726cb0 on astropy:master.

@wkerzendorf
Copy link
Member

Here you can see how your changes will look on readthedocs: http://specutils.readthedocs.org/en/doc-testing/

@dinosk
Copy link
Author

dinosk commented Mar 26, 2015

Oh I see! I ran make html in the docs and then opening the _build/html/index.html for a preview

@wkerzendorf
Copy link
Member

That does work as well - but this way we can see if it actually builds on readthedocs

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.56% when pulling 7113122 on dinossimpson:READMErst into a726cb0 on astropy:master.

wkerzendorf added a commit that referenced this pull request Apr 7, 2015
@wkerzendorf wkerzendorf merged commit 9c690c3 into astropy:master Apr 7, 2015
@wkerzendorf
Copy link
Member

@keflavich merging

@wkerzendorf
Copy link
Member

@dinossimpson thanks for the update

@dinosk
Copy link
Author

dinosk commented Apr 7, 2015

@wkerzendorf bitte schoen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants