Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement spectral coordinate object #524

Merged
merged 54 commits into from
Mar 18, 2020
Merged

Implement spectral coordinate object #524

Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
d8d282d
Implement spectral coordinate object
nmearl Sep 24, 2019
c933563
Minor changes to frame transformation behavior
nmearl Oct 14, 2019
2311176
Tweak projection calculation; differentiate rv handling
nmearl Oct 15, 2019
45fd076
Fix unit inheritance on subclass
nmearl Oct 16, 2019
ca592ea
Started adding general SkyCoord tests
astrofrog Nov 14, 2019
909d964
Make __init__ of SpectralCoord use keyword-only arguments
astrofrog Nov 14, 2019
2093f04
Refactored/tidied up test for initialization with observer and target
astrofrog Nov 14, 2019
08e98fd
Improvements to test
astrofrog Nov 14, 2019
530484c
Pass the assertion for now
astrofrog Nov 14, 2019
2fa95de
Remove incorrect assert
astrofrog Nov 14, 2019
58578fd
check rv/redshift for near-to-far cases
eteq Nov 18, 2019
8c503be
add shifting tests
eteq Nov 18, 2019
8d9e01c
implement assert_frame_allclose
eteq Nov 19, 2019
6038c18
typo fix
eteq Nov 19, 2019
59b977c
Include setter class instance checks
nmearl Nov 14, 2019
3edb5b8
None checks in rv and redshift properties
nmearl Nov 19, 2019
82f283c
Include redshift and radial velocity in arguments; add new properties
nmearl Nov 20, 2019
9d1a511
update radial_velocity_correction test to work
eteq Nov 20, 2019
c4a4ecc
Fix rv calculation when rv is explicitly provided
nmearl Nov 29, 2019
c03efaf
Passing science case tests with None implementation
nmearl Dec 6, 2019
a6bcd46
Implicitly create observer/target pairs
nmearl Dec 1, 2019
e123b5f
Fix incorrect asserts for default observer/target case
nmearl Dec 2, 2019
138c4ce
Avoid issue with astropy Galactic coordinates
nmearl Dec 4, 2019
fe18146
Try composing default frame objects more robust
nmearl Dec 5, 2019
b3f1703
Remove numpy compat imports
nmearl Feb 23, 2020
9350deb
Revamp based on discussions in #422
nmearl Feb 26, 2020
81350ff
Clean up class object creation; get tests passing
nmearl Feb 26, 2020
a71ed1a
Avoid validation on None inputs
nmearl Feb 26, 2020
3bc2124
Maintain hidden reference to implicity frames
nmearl Feb 26, 2020
db0461d
Update tests to properly handle rv/z
nmearl Feb 26, 2020
c1f6e0c
Fix mock target creation when target not provided
nmearl Mar 3, 2020
cd1385e
Include simple methods for updating rv/redshift
nmearl Mar 3, 2020
4b387d4
Replacing remaining rest reference
nmearl Mar 10, 2020
7e0dc4a
Update equivalency handling in override
nmearl Mar 10, 2020
8b512a0
switch keck to example site
eteq Mar 13, 2020
e6f9528
initialization of asteroid case
eteq Mar 13, 2020
9e236c6
complete test_asteroid_velocity_frame_shifts
eteq Mar 15, 2020
f682236
implement misc tests of rv/redshift/init behavior
eteq Mar 15, 2020
e2c9b51
add test_los_shift
eteq Mar 15, 2020
886bcac
Update redshift radial velocity equivalency
nmearl Mar 16, 2020
5c4a418
Break out target creation into separate method
nmearl Mar 16, 2020
993ba98
If rv exists, assign on coordinate validation
nmearl Mar 16, 2020
88efe4c
Re-create implicit target when setting observer
nmearl Mar 16, 2020
e9853e3
Fix position normalization in rv calculation
nmearl Mar 16, 2020
62e03fb
Update redshift and rv tests for spectral coord
nmearl Mar 16, 2020
8903e6f
Fix los shift behavior
nmearl Mar 17, 2020
708aedf
Move projection and norm calculations into methods
nmearl Mar 17, 2020
b9076ea
Fix basic behavior test for rv calcs with target
nmearl Mar 17, 2020
e8dac62
Update method calls
nmearl Mar 17, 2020
5e4ff5f
Allow auto creation of observer from target
nmearl Mar 17, 2020
b150078
Handle lack of precision in projection calculation
nmearl Mar 17, 2020
633f01c
Properly transform frames in differentials update
nmearl Mar 17, 2020
9259a80
Include tolerance in rv allclose check
nmearl Mar 17, 2020
691a68d
Fix final review comments
nmearl Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading