Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: unify react-component with html-template #327

Merged

Conversation

magicmatatjahu
Copy link
Member

Description

Unify component with with html-template. For more info see asyncapi/shape-up-process#83 and #265

Changes:

  • remove Fiori styling and start using TailwindCSS - theming at the moment won't be possible, we want to add it in the future in simplifier form that currently - see Unify HTML template and React component shape-up-process#83 -> Don't support theming section. @asyncapi/react-component/lib/styles/fiori.css is deprecated.
  • default styles now is in @asyncapi/react-component/styles/default.min.css
  • start supporting esm and cjs modules. Prepare also compatible with browser umd module.
  • supporting almost everything from JSON Schema draft-07 except dependencies and true/false schemas (due to bug in parser Handling schema true and false parser-js#232)
  • supporting from AsyncAPI 2.0.0 everything except:
    • id
    • operationId
    • externalDocs in operation
    • discriminator in AsyncAPI JSON Schema
  • schema prop can be instance of AsyncAPIDocument
  • config prop is changed:
    • remove expand object due to fact that we want to change expanding functionality
    • move showErrors to show.errors
    • remove show.schemas
    • remove show.sidebar
    • rename show.channels to show.operations
    • remove pushStateBehaviour due to fact that we want to change expanding functionality

I added feat: because I don't think that the current changes (although big) are immediately suitable for 1.0.0 or even 1.0.0-alphaX. We should go further from 0.24.0 and only when we stabilize the component we should go with 1.0.0. Also with 1.0.0-alpha there will be problems with semantic-releases (or not (: ?) @fmvilas @derberg Any thoughts mates?

Thanks for @aeworxet for helping me in this journey! 😄

Related issue(s)
See asyncapi/shape-up-process#83
See #265

@sonarcloud
Copy link

sonarcloud bot commented May 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you know you can do empty commit?

@magicmatatjahu
Copy link
Member Author

@derberg A man learns all his life 😅

@magicmatatjahu magicmatatjahu merged commit 6b64a64 into asyncapi:next May 4, 2021
@magicmatatjahu magicmatatjahu deleted the next-branches/fix-first-release branch May 4, 2021 11:01
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants