feat!: unify react-component with html-template #327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unify component with with html-template. For more info see asyncapi/shape-up-process#83 and #265
Changes:
@asyncapi/react-component/lib/styles/fiori.css
is deprecated.@asyncapi/react-component/styles/default.min.css
esm
andcjs
modules. Prepare also compatible with browser umd module.dependencies
andtrue/false
schemas (due to bug in parser Handling schema true and false parser-js#232)id
operationId
externalDocs
in operationdiscriminator
in AsyncAPI JSON Schemaschema
prop can be instance ofAsyncAPIDocument
config
prop is changed:expand
object due to fact that we want to change expanding functionalityshowErrors
toshow.errors
show.schemas
show.sidebar
show.channels
toshow.operations
pushStateBehaviour
due to fact that we want to change expanding functionalityI added
feat:
because I don't think that the current changes (although big) are immediately suitable for 1.0.0 or even 1.0.0-alphaX. We should go further from 0.24.0 and only when we stabilize the component we should go with 1.0.0. Also with 1.0.0-alpha there will be problems with semantic-releases (or not (: ?) @fmvilas @derberg Any thoughts mates?Thanks for @aeworxet for helping me in this journey! 😄
Related issue(s)
See asyncapi/shape-up-process#83
See #265