docs: add custom styling & custom logo #531
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
@thim81 Hi! I will review tomorrow, don't worry :) |
Co-authored-by: Samriddhi <Agrawalsamriddhi83@gmail.com>
|
If possible do a "Squash and merge" since the spelling & indenting corrections are too much :-) |
There was a problem hiding this comment.
@thim81 Thanks for awesome contribution! However I have 7 suggestions how we should improve new docs :) Please refer to them.
Don't worry, we always squash before merge, we have enabled it on the Github side :) |
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
@thim81 Hi! Please ad in some places missed "" chars because I see that we have broken md file. Github suggestion system has problem with ""...
|
@magicmatatjahu The missing quotes are back and the page should look OK again. |
There was a problem hiding this comment.
Ok, last suggestion and for me everything looks good! @alequetzalli Do you wanna also make review?
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Co-authored-by: Alejandra Quetzalli <alejandra.quetzalli@postman.com>
|
@alequetzalli Thanks for review! :) |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@magicmatatjahu According to Github there is a still a change request open? But from what I can see all the comments have been resolved? Can you tell me if you were missing something? |
|
@thim81 Hi! I felt bad on Thursday and Friday and didn't work. Sorry for the delay. Everything is ok. Thanks for your contribution! ❤️ |
|
🎉 This PR is included in version 1.0.0-next.33 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Changes proposed in this pull request:
Related issue(s)
#530