Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: align requirement wording with RFC 2119 #139

Merged
merged 6 commits into from
Nov 9, 2022

Conversation

char0n
Copy link
Collaborator

@char0n char0n commented Jul 5, 2022

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@char0n char0n mentioned this pull request Sep 6, 2022
61 tasks
@char0n
Copy link
Collaborator Author

char0n commented Sep 6, 2022

@GeraldLoeffler @derberg can I ask you to look into this PR? Thanks!

Copy link
Collaborator

@GeraldLoeffler GeraldLoeffler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fully agreed: thanks for cleaning this up!

@char0n
Copy link
Collaborator Author

char0n commented Sep 28, 2022

Updated with changes from master.

@char0n
Copy link
Collaborator Author

char0n commented Sep 30, 2022

@derberg please allow the workflow to run after merge from master.

@derberg derberg changed the title docs: align wording with RFC 2119 docs: align requirement wording with RFC 2119 Oct 11, 2022
@derberg
Copy link
Member

derberg commented Oct 11, 2022

@char0n done

@char0n
Copy link
Collaborator Author

char0n commented Nov 9, 2022

This looks like good to go.

@char0n
Copy link
Collaborator Author

char0n commented Nov 9, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit f3bfe69 into asyncapi:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants