Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable v3 and scala for model generation #1155

Closed
wants to merge 4 commits into from

Conversation

jonaslagoni
Copy link
Member

Description
This PR updates the models command to support AsyncAPI v3 and adds scala support.

It also fixes a bug in the example document by using the Kafka example for v3 as well as using the same file name as for v2 document to stay consistent.

Related issue(s)
Fixes asyncapi/modelina#1376

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I think we need to first revert b682a8e and make another release as this is a breaking change and then this PR should make a bump and there should be a test added that will also validate the output of model generation. Then this PR will be with !

@Souvikns thoughts?

@jonaslagoni
Copy link
Member Author

@derberg it wont be possible to add a test that catches breaking changes in the model generation. The amount of variants you would need to test makes it impossible

@derberg
Copy link
Member

derberg commented Feb 27, 2024

@jonaslagoni not good, but yeah I get your point. So might be that they best would be to block autoupdates 🤔

@Souvikns ?

@jonaslagoni
Copy link
Member Author

Probably a good idea yea

Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Souvikns
Copy link
Member

Souvikns commented Mar 7, 2024

Blocking auto-updates makes sense but now we have to manually update most of the libraries, It will prevent the breaking changes but we would miss the minor features.

@derberg
Copy link
Member

derberg commented Apr 10, 2024

yeah, it sucks 😞 there is no best approach here 😞 loosing autoupdates sucks

or we complicate too much and nobody cares about output changes 🤔 nobody complains so far that latest modelina was bumped without breaking change

@jonaslagoni
Copy link
Member Author

Replaced by #1376

@jonaslagoni jonaslagoni deleted the enable_v3_and_scala branch April 19, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AsyncAPI spec v3 support in Modelina
3 participants