-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable v3 and scala for model generation #1155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derberg it wont be possible to add a test that catches breaking changes in the model generation. The amount of variants you would need to test makes it impossible |
@jonaslagoni not good, but yeah I get your point. So might be that they best would be to block autoupdates 🤔 |
Probably a good idea yea |
|
Blocking auto-updates makes sense but now we have to manually update most of the libraries, It will prevent the breaking changes but we would miss the minor features. |
yeah, it sucks 😞 there is no best approach here 😞 loosing autoupdates sucks or we complicate too much and nobody cares about output changes 🤔 nobody complains so far that latest modelina was bumped without breaking change |
Replaced by #1376 |
Description
This PR updates the
models
command to support AsyncAPI v3 and adds scala support.It also fixes a bug in the example document by using the Kafka example for v3 as well as using the same file name as for v2 document to stay consistent.
Related issue(s)
Fixes asyncapi/modelina#1376