refactor: updated and decoupled contextService logic #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
suggested changes
Sep 21, 2021
There was a problem hiding this comment.
Overall good, only this problem with console.warn Please wait for Łukasz. We'll see what he says.
Please also change the title of PR to the chore: or refactor: because as I see, you didn't use new services in source code, but only define it, so it's not feat/fix :)
|
Kudos, SonarCloud Quality Gate passed!
|
|
I see that @magicmatatjahu reviews, so no need to wait for me with approval as it is pure refactor. also, if it is pure refactor, nothing touching the functionality, this should not trigger a release but be a |
magicmatatjahu
approved these changes
Sep 22, 2021
|
@Souvikns Please change title and merge commit with |
Souvikns
changed the title
Souvikns
added a commit
that referenced
this pull request
Oct 5, 2021
* feat: updated and decoupled contextService logic * feat: creating new context when root context file is missing. * feat: removed registry & stringify issue * chore: returning context or undefined in contextAllocator save method * feat: added warning for saving file. * feat: lint fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the start of the process to move the context commands under config. In this PR I have focused on updating the
contextServicebecause of the issue discussed here. I would like to clarify what I have done here.validatecommand as it needs only one spec file path. But to support libraries like cupid and diff where more than one spec file path is needed context shall evolve as well. For that, I have created a separateIContextinterface that could be easily updated.ContextAllocatorto load context files accordingly. For now, it is loading the context file from the root file itself. This also helps in testing allowing us to create mock classes to check functionalities.ContextServicedoes not throw an error if the contextFile is not present in the root dir instead it loads undefined context.Related issue(s)
See also #38 and #37