-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Glee to TypeScript #144
Comments
I am willing to contribute but am not familiar with the repo and also did not port such a large codebase to typescript before. I always started with typescript from the start. |
Would you mind expanding on those benefits? I'm all for porting it to TS but want to make sure we make reasonable decisions.
Since this library is still in its early days, I think it's just fine to port it and then add tests. Let's not make tests become a bottleneck. |
The main benefit of typescript is the type checking during compile time. In my eyes this can avoid many errors during runtime. |
I'm sold 😄 Do you want to champion this issue? I'm sure @jonaslagoni can lend a hand if needed 😄 |
Yeah think this might help us now and also going forward for sure.
I'm happy to help here, just need some time to review the code and see how things are structured, then we can get a plan together? |
🎉 This issue has been resolved in version 0.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Reason/Context
As the spec already defines all the types and schema regarding the communication, Glee misses out on a lot of benefits that typescript could provide here. After all typescript was also written with a smiling developer in mind 😄.
Description
Porting to typescript will require large changes in the codebase. Each js file will have to be touched and also the execution process has to be altered (Either using ts-node or typescripts tsc). Since no tests exist it is going to be hard to ensure the behavior does not change and no bugs are introduced.
Approach
?
The text was updated successfully, but these errors were encountered: