Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to typescript round 1 #212

Merged
merged 13 commits into from
Jan 7, 2022

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Dec 23, 2021

Description

  • Start porting Glee to TypeScript
  • Allows the user to use TypeScript in their projects
  • Removes the existing "runtimes" mechanism. We only allow TS/JS. As suggested in Remove Java runtime #207.

Related issue(s)
#144

Comment on lines +12 to +16
public rawConnection: any
public channels: string[]
public serverName: string
public AsyncAPIServer: AsyncAPIServer
public parsedAsyncAPI: AsyncAPIDocument
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make this stuff private in the next PR. I want to leave it public so it behaves the same way as in JS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +20 to +28
public payload: any
public headers: Map<string, string>
public channel: string
public serverName: string
public connection: GleeConnection
public broadcast: boolean
public __isGleeMessage: boolean
public inbound: boolean
public outbound: boolean
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make this stuff private in the next PR. I want to leave it public so it behaves the same way as in JS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonaslagoni
Copy link
Sponsor Member

@fmvilas you have some conflicts 🙂

@fmvilas
Copy link
Member Author

fmvilas commented Jan 3, 2022

@jonaslagoni conflicts solved. Thanks for the heads up!

jonaslagoni
jonaslagoni previously approved these changes Jan 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmvilas
Copy link
Member Author

fmvilas commented Jan 7, 2022

/rtm

@fmvilas
Copy link
Member Author

fmvilas commented Jan 7, 2022

@jonaslagoni can you approve again, please?

@fmvilas
Copy link
Member Author

fmvilas commented Jan 7, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 7def76c into asyncapi:master Jan 7, 2022
@fmvilas fmvilas deleted the migrate-to-typescript-round-1 branch January 7, 2022 19:36
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants