Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to typescript (round 2) #213

Merged
merged 23 commits into from
Jan 10, 2022

Conversation

fmvilas
Copy link
Member

@fmvilas fmvilas commented Dec 24, 2021

#212 Follow up

Do not review until #212 is merged 🙏

Fixes #144

@fmvilas fmvilas force-pushed the migrate-to-typescript-round-2 branch from daa18c8 to de8c254 Compare December 28, 2021 11:38
@fmvilas fmvilas marked this pull request as ready for review December 30, 2021 17:03
@fmvilas fmvilas force-pushed the migrate-to-typescript-round-2 branch from d2adc93 to 3f98f92 Compare January 3, 2022 16:04
@fmvilas fmvilas force-pushed the migrate-to-typescript-round-2 branch from 127a580 to dd02eed Compare January 7, 2022 19:58
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a couple of files under runtimes/java that needs to be removed.

And just one small suggestion, otherwise it looks great!

.eslintignore Outdated Show resolved Hide resolved
jonaslagoni
jonaslagoni previously approved these changes Jan 10, 2022
jonaslagoni
jonaslagoni previously approved these changes Jan 10, 2022
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, not sure how relevant though.

src/lib/logger.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fmvilas fmvilas merged commit 7dab58f into asyncapi:master Jan 10, 2022
@fmvilas fmvilas deleted the migrate-to-typescript-round-2 branch January 10, 2022 16:43
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port Glee to TypeScript
3 participants