Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove node-ipc dependency #274

Merged
merged 2 commits into from
Mar 20, 2022
Merged

fix: remove node-ipc dependency #274

merged 2 commits into from
Mar 20, 2022

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Mar 17, 2022 •
edited
Loading

Description

This PR removes the unused node-ipc dependency.

@jonaslagoni jonaslagoni changed the title update dependencies fix: patch CVE-2022-23812 Mar 17, 2022
@coveralls
Copy link

coveralls commented Mar 17, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1999118217

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.57%
Totals Coverage Status
Change from base Build 1929261406: 0.0%
Covered Lines: 232
Relevant Lines: 276
💛 - Coveralls

@derberg
Copy link
Member

derberg commented Mar 17, 2022

do we need it? it is actually not used in the code, we can just remove it and do not need CVE cause it was anyway locked in package-lock

@jonaslagoni jonaslagoni changed the title fix: patch CVE-2022-23812 fix: remove node-ipc Mar 17, 2022
@jonaslagoni jonaslagoni changed the title fix: remove node-ipc fix: remove node-ipc dependency Mar 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

derberg
derberg approved these changes Mar 17, 2022
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 even thought I'm not codeowner 😆

@jonaslagoni jonaslagoni mentioned this pull request Mar 20, 2022
Closed
@fmvilas
Copy link
Member

fmvilas commented Mar 20, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit bec021e into asyncapi:master Mar 20, 2022
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.10.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonaslagoni jonaslagoni deleted the fix_security_problem branch July 28, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmvilas fmvilas fmvilas approved these changes

@derberg derberg derberg approved these changes

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jonaslagoni @coveralls @derberg @fmvilas @asyncapi-bot