Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simplify patternProperties #153

Merged
merged 7 commits into from
Apr 28, 2021

Conversation

jonaslagoni
Copy link
Member

@jonaslagoni jonaslagoni commented Apr 26, 2021

Description
This PR moves the patternProperties property from Schema to CommonModel to allow rendering of pattern properties.

Beside this main feature:

  • Fixed unnecessary ignore of lint rule.
  • Added better docs
  • Added missing tests for additionalProperties merge

Related issue(s)
Solves #43

@jonaslagoni jonaslagoni changed the title feat: add patternProperties to CommonModel feat: Simplify patternProperties Apr 26, 2021
@jonaslagoni jonaslagoni changed the title feat: Simplify patternProperties feat: simplify patternProperties Apr 26, 2021
magicmatatjahu
magicmatatjahu previously approved these changes Apr 28, 2021
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only one change :)

src/simplification/SimplifyPatternProperties.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@jonaslagoni jonaslagoni merged commit 495f763 into asyncapi:master Apr 28, 2021
@jonaslagoni jonaslagoni deleted the feature/pattern_properties branch April 28, 2021 09:54
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants