Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add python constraint tests #1703

Merged
merged 12 commits into from
Jan 1, 2024
Merged

test: add python constraint tests #1703

merged 12 commits into from
Jan 1, 2024

Conversation

devilkiller-ag
Copy link
Member

Description

Added test for python tests

Related Issue

Fixes #1669

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

@netlify Netlify
Copy link

netlify bot commented Dec 27, 2023 •
edited
Loading

✅ Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 1f4f1a3
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/6592d8572732390008718923

@devilkiller-ag
Copy link
Member Author

@jonaslagoni I found some minor bugs in print statements of javascript constraint tests regarding name formatting. Should I fix that in this PR or open a Good First Issue?

@devilkiller-ag devilkiller-ag marked this pull request as draft December 27, 2023 05:25
@jonaslagoni
Copy link
Member

jonaslagoni commented Dec 27, 2023 •
edited
Loading

@devilkiller-ag For small things, feel free to bundle a few things, but general guideline is to split up PRs 🙂

@devilkiller-ag
Copy link
Member Author

devilkiller-ag commented Dec 27, 2023 •
edited
Loading

@jonaslagoni It's just a minor mistake in a sentence, I will rectify it. Do we have a problem with the sonarcloud code duplication warning?

@devilkiller-ag devilkiller-ag self-assigned this Dec 27, 2023
@devilkiller-ag devilkiller-ag marked this pull request as ready for review December 27, 2023 12:57
@jonaslagoni
Copy link
Member

@devilkiller-ag no, you can ignore it 🙂

jonaslagoni
jonaslagoni requested changes Dec 27, 2023
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are failing, double check the implementation to make sure the tests matches 🙂

@jonaslagoni
Copy link
Member

@devilkiller-ag any update here? 🙂

@devilkiller-ag
Copy link
Member Author

Hi @jonaslagoni, I faced some test errors earlier, I will solve them and complete this PR by tomorrow!

@coveralls
Copy link

coveralls commented Jan 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7378260521

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 92.364%
Totals Coverage Status
Change from base Build 7372737042: 0.03%
Covered Lines: 5869
Relevant Lines: 6193
💛 - Coveralls

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

51.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@devilkiller-ag
Copy link
Member Author

devilkiller-ag commented Jan 1, 2024 •
edited
Loading

@jonaslagoni This PR is ready for review now!

@jonaslagoni
Copy link
Member

Nope, not at all 👍

jonaslagoni
jonaslagoni approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👌

@jonaslagoni jonaslagoni merged commit bffee57 into asyncapi:master Jan 1, 2024
14 of 15 checks passed
@jonaslagoni
Copy link
Member

@all-contributors please add @devilkiller-ag for docs, maintenance, test, code, design, review

@allcontributors allcontributors bot mentioned this pull request Jan 1, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@jonaslagoni

I've put up a pull request to add @devilkiller-ag! 🎉

@devilkiller-ag devilkiller-ag deleted the ag_tests branch January 2, 2024 04:41
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonaslagoni jonaslagoni jonaslagoni approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

@kennethaasan kennethaasan Awaiting requested review from kennethaasan kennethaasan is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

@Samridhi-98 Samridhi-98 Awaiting requested review from Samridhi-98 Samridhi-98 is a code owner

Assignees

@devilkiller-ag devilkiller-ag

Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Python constraint tests
4 participants
@devilkiller-ag @jonaslagoni @coveralls @asyncapi-bot