Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added loading animation in output #2042

Closed
wants to merge 1 commit into from

Conversation

Alokih
Copy link

@Alokih Alokih commented Jun 15, 2024

Description

Added a loading... message in output, if there is any change in input field or other general options

Related Issue

Fixes: #1725

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Jun 15, 2024

Deploy Preview for modelina ready!

Name Link
🔨 Latest commit dc452f7
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/666ddde94bcd9d0008f442c1
😎 Deploy Preview https://deploy-preview-2042--modelina.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

sonarcloud bot commented Jun 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alokih does not seem to work, at least we still see the old generated models with no loading screen when changing input and options.

Please make sure you test the preview that Netlify creates 🙂

@Alokih
Copy link
Author

Alokih commented Jun 19, 2024

ok @jonaslagoni , I'll try to do it

@devilkiller-ag devilkiller-ag changed the title Added loading animation in output feat: added loading animation in output Jun 22, 2024
@coveralls
Copy link

coveralls commented Jun 22, 2024

Pull Request Test Coverage Report for Build 9530098031

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.303%

Totals Coverage Status
Change from base Build 9483170018: 0.0%
Covered Lines: 5996
Relevant Lines: 6327

💛 - Coveralls

Copy link
Member

@devilkiller-ag devilkiller-ag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When changing options, why we see blank on output side, instead we need loading... animation. Also you can notice that the loading... apears after the code is updated.

2024-06-23.01-47-28.mp4

@jonaslagoni
Copy link
Member

Closing as no progress, feel free to re-open if you get back to it @Alokih

@Alokih Alokih deleted the loading-animation branch August 13, 2024 17:45
@Alokih Alokih restored the loading-animation branch August 13, 2024 17:45
@Alokih Alokih deleted the loading-animation branch August 13, 2024 17:46
@Alokih Alokih restored the loading-animation branch August 13, 2024 17:47
@Alokih Alokih deleted the loading-animation branch August 13, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add loading animation for when playground generate models
4 participants