-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LEGO DTO #221
LEGO DTO #221
Conversation
…re/dto-from-AsyncApi.Net
Hi @VisualBean , I've finished this, please take a look. Most of all, I am concerned about the correctness of the build of the message payload, I did not understand this contract well in places. There is also a big disadvantage in this implementation - I do not use the component section at all, I do not yet understand what problems this can turn into, but I guess it's not good... Please see how the time is going to be) |
Looks great! Ive only done a preliminary review on my phone (currently on holidays). Components are however not necesary if you just inline everything. (Whether people want that or not is however a cause for concern on this) For the message payload, in the current version of asyncapi.net, there is only support for jsonschema, however Avro is stewing in vNext (until i get external reference resolution to work). Ill have s closer look when im back next week. |
All right, I'll be waiting! I've never worked with Avro, I can't tell you anything here... But this gave me the idea to check how all this will work on protobuf, I'll do it for now) |
What i did for Avro is basically just the classes and turning message.payload into an IMessagePayload. But in terms of refs and components. So either its created as a reference (id and type -> which corresponds to a placement in the components section) (i.e If it has a reference, itll be looked up and inlined (depending on Writer and Reader settings) in the final document. |
test/Saunter.Tests/AttributeProvider/DocumentGenerationTests/ClassAttributesTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am really missing a "From this setup using Saunter, we expect this document to be produced" kind of test.
or maybe i missed it?
Otherwise everything looks good i think - cant immediately spot anything.
What about bindings?
Are these passed through the annotations?
The conflict should be easy as all of those files have been removed.
after this pull request, i will be implementing integration tests for the project, this will be one of them) the lego package with bindings is connected, I will add a test that will check them + eliminate conflicts. I'll do it today or tomorrow |
done:
|
@VisualBean Can we release it? It seems to me that we have already collected a lot of changes and it's time |
You said something about following up with tests. |
Yes, I plan to create a comprehensive test model of the project and implement it. Now then I'll create an issue and start working on it) |
Description
----- additional q
Related issue(s)
#188