feat: add specific binding schemas #224
Conversation
jonaslagoni
requested review from
fmvilas,
derberg,
dalelane and
asyncapi-bot-eve
as code owners
jonaslagoni
changed the title
|
Kudos, SonarCloud Quality Gate passed!聽 聽
|
There was a problem hiding this comment.
@jonaslagoni Two things:
-
It fixes an issue where we allow all extensions regardless of the use of x-, which should not be allowed. Whether we want to propagate this across all versions, not so sure? 馃
Do you mean that bug was only in
bindingsObject? -
I think that you should also update
Yes, as you can see here old vs new: https://github.com/asyncapi/spec-json-schemas/pull/224/files#diff-ecc755fd231eb52860aef0a5ea2c062296e87a0e38e1d1781d1782d47f690fe2R2-R8 We allowed the extension of any key, instead of only with specification extension
Agreed, that will be next after this, and #225 is merged. |
|
/rtm |
|
馃帀 This PR is included in version 3.2.0-next-major-spec.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
|
馃帀 This PR is included in version 5.0.0-next-major-spec.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
|
馃帀 This PR is included in version 6.0.0-next-major-spec.1 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Description
This PR adds 2 changes to the JSON Schema documents.
x-, which should not be allowed. Whether we want to propagate this across all versions, not so sure? 馃bindingsObjectinto the 4 specific bindings for operation, channel, message, and server.Related to asyncapi/spec#507
Related to asyncapi/bindings#113