-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add specific binding schemas #224
feat: add specific binding schemas #224
Conversation
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonaslagoni Two things:
-
It fixes an issue where we allow all extensions regardless of the use of x-, which should not be allowed. Whether we want to propagate this across all versions, not so sure? 🤔
Do you mean that bug was only in
bindingsObject
? -
I think that you should also update
"serverBindings": {
Yes, as you can see here old vs new: https://github.com/asyncapi/spec-json-schemas/pull/224/files#diff-ecc755fd231eb52860aef0a5ea2c062296e87a0e38e1d1781d1782d47f690fe2R2-R8 We allowed the extension of any key, instead of only with specification extension
Agreed, that will be next after this, and #225 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/rtm |
🎉 This PR is included in version 3.2.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 5.0.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 6.0.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
This PR adds 2 changes to the JSON Schema documents.
x-
, which should not be allowed. Whether we want to propagate this across all versions, not so sure? 🤔bindingsObject
into the 4 specific bindings for operation, channel, message, and server.Related to asyncapi/spec#507
Related to asyncapi/bindings#113