Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change clientId type on kafka operation to schema #648

Merged
merged 5 commits into from
Dec 21, 2021
Merged

docs: change clientId type on kafka operation to schema #648

merged 5 commits into from
Dec 21, 2021

Conversation

KhudaDad414
Copy link
Member

clientId on kafka operation should be a schema"

following the discussion in #647, the kafka example should follow the bindings specification.

@KhudaDad414 KhudaDad414 added the ✏️ Editorial PR is non-normative or does not influence implementation label Nov 10, 2021
github-actions[bot]
github-actions bot reviewed Nov 10, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@KhudaDad414 KhudaDad414 linked an issue Nov 10, 2021 that may be closed by this pull request
Kafka clientId in OperationBinding is string in example #647
Closed
smoya
smoya approved these changes Nov 10, 2021 •
edited
Loading
View reviewed changes
@smoya smoya self-requested a review November 12, 2021 17:37
smoya
smoya reviewed Nov 12, 2021
View reviewed changes
Copy link
Member

@smoya smoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however, I'm not sure if fix should be the commit prefix or rather docs.
@derberg wdyt?

@smoya smoya self-requested a review November 12, 2021 17:41
@derberg
Copy link
Member

derberg commented Dec 6, 2021

@smoya no, it is definitely not fix as it is related to docs and not spec itself.

@derberg
Copy link
Member

derberg commented Dec 6, 2021

@KhudaDad414 please adjust the PR title and pink one of the Kafka-binding maintainers so they are aware of this PR

@KhudaDad414 KhudaDad414 changed the title fix: change clientId type on kafka operation to schema docs: change clientId type on kafka operation to schema Dec 6, 2021
dalelane
dalelane approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@dalelane dalelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

fmvilas
fmvilas approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@fmvilas fmvilas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 👍

@KhudaDad414
Copy link
Member Author

/rtm

@derberg
Copy link
Member

derberg commented Dec 21, 2021

/rtm

@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@asyncapi-bot asyncapi-bot merged commit 7b64691 into asyncapi:master Dec 21, 2021
@derberg
Copy link
Member

derberg commented Dec 21, 2021

@allcontributors please add @KhudaDad414 for example, bug

@allcontributors allcontributors bot mentioned this pull request Dec 21, 2021
Merged
@allcontributors
Copy link
Contributor

@derberg

I've put up a pull request to add @KhudaDad414! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.0-2022-01-release.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@fmvilas fmvilas fmvilas approved these changes

@smoya smoya smoya approved these changes

@dalelane dalelane dalelane approved these changes

@derberg derberg Awaiting requested review from derberg derberg is a code owner

Assignees
No one assigned
Labels
✏️ Editorial PR is non-normative or does not influence implementation ready-to-merge released on @2022-01-release released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kafka clientId in OperationBinding is string in example
6 participants
@KhudaDad414 @derberg @asyncapi-bot @fmvilas @smoya @dalelane