Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge spa-scratch branch #133

Merged
merged 18 commits into from
Oct 26, 2021
Merged

feat: merge spa-scratch branch #133

merged 18 commits into from
Oct 26, 2021

Conversation

magicmatatjahu
Copy link
Member

Description

Merge spa-scratch branch to the master:

  • replace old implementation of Studio to new one, from NextJS to simple SPA
  • integrate monaco-editor
  • add navigation
  • render asyncapi-react component
  • visualise AsyncAPI document by event flow
  • add parser and converter functionalities

Related issue(s)
See #80

magicmatatjahu and others added 18 commits September 23, 2021 16:10
@magicmatatjahu
refactor: remove old implementation (asyncapi#87)
6bd9e0d
@magicmatatjahu
chore: init new version of Studio (asyncapi#96)
d702cd3
@magicmatatjahu
chore: add navigation (asyncapi#97)
b19c219
@magicmatatjahu
chore: add editor dropdown (asyncapi#98)
943e11b
@magicmatatjahu
chore: add terminal (asyncapi#99)
2068441
@magicmatatjahu
chore: add convert functionality (asyncapi#100)
3d8a8f2
@magicmatatjahu
feat: show convert modal when user uses older versions of spec (async…
4070ad0 
…api#105)
@magicmatatjahu
feat: add new functionalities to the editor dropdown (asyncapi#108)
7d53786
@magicmatatjahu
chore: add eslint (asyncapi#112)
d4d7fc2
@magicmatatjahu @jonaslagoni
feat: support URL parameters (asyncapi#113)
86fa4ea 
Co-authored-by: Jonas Lagoni <jonas-lt@live.dk>
@magicmatatjahu
feat: add to editor an error markers (asyncapi#116)
c293c7d
@magicmatatjahu
feat: add community links in toolbar (asyncapi#124)
d68a1b5
@boyney123 @magicmatatjahu
feat: adding visualiser to the new studio (asyncapi#125) (asyncapi#128)
8b95cd9 
Co-authored-by: Maciej Urbańczyk <urbanczyk.maciej.95@gmail.com>
Co-authored-by: David Boyne <davidboyne@Davids-MBP.lan>
@magicmatatjahu
feat: add favicons and change basic meta for index.html (asyncapi#132)
8393650
@magicmatatjahu
Merge branch 'master' into spa-scratch-to-master
e7450c2
@magicmatatjahu
add sonarcloud properties
6dda2de
@magicmatatjahu
fix some solar errors
1933e82
@magicmatatjahu
fix one type
a8b3054
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@magicmatatjahu
Copy link
Member Author

@fmvilas We have some small bugs on sonarcloud but I think that they are not so necessary to fix. In the next PR I will update Readme as well as I will configure semantic-release. Please approve :)

@boyney123
Copy link
Contributor

Happy with the branch, 215 files are quite big to review, but the application and it's architecture seems to be in a working state when I was working with it (looked good). So based on my experience I'm happy with it going in.

Guess any details we can review/refactor as we come across them?

@magicmatatjahu magicmatatjahu merged commit b8ea164 into asyncapi:master Oct 26, 2021
@magicmatatjahu magicmatatjahu deleted the spa-scratch-to-master branch October 26, 2021 13:02
@fmvilas
Copy link
Member

fmvilas commented Oct 26, 2021

🚀

@fmvilas fmvilas mentioned this pull request Oct 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyney123 boyney123 boyney123 approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magicmatatjahu @boyney123 @fmvilas